search

chipKIT32 / chipKIT-core

Downloadable chipKIT core for use with Arduino 1.6 - 1.8+ IDE, PlatformIO, and UECIDE
http://chipkit.net/
Apache License 2.0
59 stars 53 forks source link

Wire.write() to support passing uint32_t (and by promotion uint_16_t). #420

Closed JacobChrist closed 6 years ago

JacobChrist commented 6 years ago

Compiles, not tested on hardware. I think its going to work.

chipkitbot commented 6 years ago

Can one of the admins verify this patch?

EmbeddedMan commented 6 years ago

ok to test

On Tue, Jun 5, 2018 at 2:17 PM, chipKIT Bot notifications@github.com wrote:

Can one of the admins verify this patch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/420#issuecomment-394828013, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCI6d9kOjqDe9GTt5VR2D82IJGYiUks5t5tktgaJpZM4UYLyU .

adamwolf commented 6 years ago

retest this please

(this is a directive to chipkitbot, not a code quality judgement 😄 )

EmbeddedMan commented 6 years ago

10 print "retest this please" 20 goto 10

run

Will that help?

On Tue, Jun 5, 2018 at 11:06 PM, Adam Wolf notifications@github.com wrote:

retest this please

one last time before bed, i'll look tomorrow

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/420#issuecomment-394933778, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCOWPmAbk3C8BISflie7zcfDxYmfFks5t51VYgaJpZM4UYLyU .

JacobChrist commented 6 years ago

What do you me retest? I never tested in the first place. I will test tomorrow when I am back at school. On a side note my coworkers often liken me to a robot.

Jacob

On Wed, Jun 6, 2018, 7:37 AM Adam Wolf notifications@github.com wrote:

ok to retest

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/420#issuecomment-395091662, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMGa40GDLY9cpgFdci1NVRLKfYgj0-aks5t5-kigaJpZM4UYLyU .

EmbeddedMan commented 6 years ago

These messages are for chipKIT bot, not us humans. It will also be great for you to test the change (although I agree with you that it should not cause any problems), but Adam is trying to kick chipKIT bot into rebuilding this pull request.

*Brian

On Wed, Jun 6, 2018 at 9:45 AM, Jacob Christ notifications@github.com wrote:

What do you me retest? I never tested in the first place. I will test tomorrow when I am back at school. On a side note my coworkers often liken me to a robot.

Jacob

On Wed, Jun 6, 2018, 7:37 AM Adam Wolf notifications@github.com wrote:

ok to retest

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/420# issuecomment-395091662, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAMGa40GDLY9cpgFdci1NVRLKfYgj0-aks5t5-kigaJpZM4UYLyU .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/420#issuecomment-395094566, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCLr67WUXrBSJNV3NyoaLTbepPKvlks5t5-rzgaJpZM4UYLyU .

JacobChrist commented 6 years ago

I know. I guess being a smartass doesn't come across in written form too well.

Jacob

On Wed, Jun 6, 2018, 8:12 AM Brian Schmalz notifications@github.com wrote:

These messages are for chipKIT bot, not us humans. It will also be great for you to test the change (although I agree with you that it should not cause any problems), but Adam is trying to kick chipKIT bot into rebuilding this pull request.

*Brian

On Wed, Jun 6, 2018 at 9:45 AM, Jacob Christ notifications@github.com wrote:

What do you me retest? I never tested in the first place. I will test tomorrow when I am back at school. On a side note my coworkers often liken me to a robot.

Jacob

On Wed, Jun 6, 2018, 7:37 AM Adam Wolf notifications@github.com wrote:

ok to retest

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/420# issuecomment-395091662, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAMGa40GDLY9cpgFdci1NVRLKfYgj0-aks5t5-kigaJpZM4UYLyU .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/chipKIT32/chipKIT-core/pull/420#issuecomment-395094566 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAbeCLr67WUXrBSJNV3NyoaLTbepPKvlks5t5-rzgaJpZM4UYLyU

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/420#issuecomment-395104884, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMGa4Nwwdm-srrFo9KZe5Iq_l8Cj2AJks5t5_FpgaJpZM4UYLyU .

adamwolf commented 6 years ago

retest this please

JacobChrist commented 6 years ago

I have confirmed that this changes work in with the Ada fruit example program and library. I think its ready to merge.