chipKIT32 / chipKIT-core

Downloadable chipKIT core for use with Arduino 1.6 - 1.8+ IDE, PlatformIO, and UECIDE
http://chipkit.net/
Apache License 2.0
59 stars 53 forks source link

Fix build error for HelvePic32a and HelvePic32SMDa. #437

Closed xxxajk closed 6 years ago

xxxajk commented 6 years ago

Path names are case sensitive on Linux, and probabbly MacOS too. You won't see this error happen on Win.

In file included from ~/.arduino15/packages/chipKIT/hardware/pic32/2.0.5/cores/pic32/WProgram.h:9:0,
                 from ~/.arduino15/packages/chipKIT/hardware/pic32/2.0.5/cores/pic32/Arduino.h:4,
                 from /tmp/arduino_build_971852/sketch/Blink.ino.cpp:1:
~/.arduino15/packages/chipKIT/hardware/pic32/2.0.5/cores/pic32/pins_arduino.h:276:24: fatal error: Board_Defs.h: No such file or directory
 #include <Board_Defs.h>
                        ^

This simple patch fixes the problem.

chipkitbot commented 6 years ago

Can one of the admins verify this patch?

EmbeddedMan commented 6 years ago

ok to test

On Wed, Sep 26, 2018 at 12:06 AM chipKIT Bot notifications@github.com wrote:

Can one of the admins verify this patch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/437#issuecomment-424586128, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCEtnMfkqnxGqII9rEFRfozxTAC4Dks5uews6gaJpZM4W56AT .

xxxajk commented 6 years ago

Second patch is for the WiFi module. The INLINE statements cause the link stage to fail. I wanted to make this a separate pull request, but for whatever reason, without doing another fork, or branch, github/git decided to just include it. ARGH :-)

EmbeddedMan commented 6 years ago

Looks good. Merging.

xxxajk commented 6 years ago

Cool. Thanks!