chipKIT32 / chipKIT-importer

chipKIT importer plugin for MPLAB X
Apache License 2.0
6 stars 2 forks source link

Compiler requirement tied to test candidate version #10

Closed lstandage closed 7 years ago

lstandage commented 7 years ago

The importer currently requires the following version of XC32:

1.43-TC5

But installing 1.43-RC1 gives an error.

It looks like Requirements.java has the version too long and needs to be shortened.

gholdys commented 7 years ago

Fixed with version 0.9.11. Please verify.

EmbeddedMan commented 7 years ago

Do we have a link for the new RC compiler?

Brian

On Mar 8, 2017 11:57 AM, "Grzegorz Hołdys" notifications@github.com wrote:

Fixed with version 0.9.11. Please verify.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10#issuecomment-285116760, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCP8nnt3g-AXXUfhnPB1-8Qw-H2sBks5rjuvvgaJpZM4MXGLS .

guymc commented 7 years ago

Uploading now, will appear here in about 5 minutes:

https://microchip.box.com/s/3rtrjbct27femocf6xyvfdsjxp633xrs

Guy

From: Brian Schmalz [mailto:notifications@github.com] Sent: Wednesday, March 08, 2017 10:59 AM To: chipKIT32/chipKIT-importer Cc: Subscribed Subject: Re: [chipKIT32/chipKIT-importer] Compiler requirement tied to test candidate version (#10)

Do we have a link for the new RC compiler?

Brian

On Mar 8, 2017 11:57 AM, "Grzegorz Hołdys" notifications@github.com<mailto:notifications@github.com> wrote:

Fixed with version 0.9.11. Please verify.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10#issuecomment-285116760, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCP8nnt3g-AXXUfhnPB1-8Qw-H2sBks5rjuvvgaJpZM4MXGLS .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/chipKIT32/chipKIT-importer/issues/10#issuecomment-285117214, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AArtqqNcJA76p2VYrMlNQHKjI2nmzfcpks5rjuxLgaJpZM4MXGLS.

EmbeddedMan commented 7 years ago

Interesting - I'm still using plugin version 0.9.9, and with the new compiler, (1.43 RC1) I had no trouble importing or building a sketch.

Hmmm.

*Brian

On Wed, Mar 8, 2017 at 12:08 PM, guymc notifications@github.com wrote:

Uploading now, will appear here in about 5 minutes:

https://microchip.box.com/s/3rtrjbct27femocf6xyvfdsjxp633xrs

Guy

From: Brian Schmalz [mailto:notifications@github.com] Sent: Wednesday, March 08, 2017 10:59 AM To: chipKIT32/chipKIT-importer Cc: Subscribed Subject: Re: [chipKIT32/chipKIT-importer] Compiler requirement tied to test candidate version (#10)

Do we have a link for the new RC compiler?

Brian

On Mar 8, 2017 11:57 AM, "Grzegorz Hołdys" <notifications@github.com< mailto:notifications@github.com>> wrote:

Fixed with version 0.9.11. Please verify.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10# issuecomment-285116760, or mute the thread https://github.com/notifications/unsubscribe- auth/AAbeCP8nnt3g-AXXUfhnPB1-8Qw-H2sBks5rjuvvgaJpZM4MXGLS .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ chipKIT32/chipKIT-importer/issues/10#issuecomment-285117214, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ AArtqqNcJA76p2VYrMlNQHKjI2nmzfcpks5rjuxLgaJpZM4MXGLS.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10#issuecomment-285119865, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCG-G2ANsrqhup8WrIysu7Iu5dvBjks5rju6GgaJpZM4MXGLS .

lstandage commented 7 years ago

Did you remove the previous compiler version?

On Mar 8, 2017 11:33 AM, "Brian Schmalz" notifications@github.com wrote:

Interesting - I'm still using plugin version 0.9.9, and with the new compiler, (1.43 RC1) I had no trouble importing or building a sketch.

Hmmm.

*Brian

On Wed, Mar 8, 2017 at 12:08 PM, guymc notifications@github.com wrote:

Uploading now, will appear here in about 5 minutes:

https://microchip.box.com/s/3rtrjbct27femocf6xyvfdsjxp633xrs

Guy

From: Brian Schmalz [mailto:notifications@github.com] Sent: Wednesday, March 08, 2017 10:59 AM To: chipKIT32/chipKIT-importer Cc: Subscribed Subject: Re: [chipKIT32/chipKIT-importer] Compiler requirement tied to test candidate version (#10)

Do we have a link for the new RC compiler?

Brian

On Mar 8, 2017 11:57 AM, "Grzegorz Hołdys" <notifications@github.com< mailto:notifications@github.com>> wrote:

Fixed with version 0.9.11. Please verify.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10# issuecomment-285116760, or mute the thread https://github.com/notifications/unsubscribe- auth/AAbeCP8nnt3g-AXXUfhnPB1-8Qw-H2sBks5rjuvvgaJpZM4MXGLS .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ chipKIT32/chipKIT-importer/issues/10#issuecomment-285117214, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ AArtqqNcJA76p2VYrMlNQHKjI2nmzfcpks5rjuxLgaJpZM4MXGLS.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10# issuecomment-285119865, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCG- G2ANsrqhup8WrIysu7Iu5dvBjks5rju6GgaJpZM4MXGLS .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10#issuecomment-285127012, or mute the thread https://github.com/notifications/unsubscribe-auth/ALyFRThu-glwfiiWI1wb-PnTKxNgFKlhks5rjvSLgaJpZM4MXGLS .

EmbeddedMan commented 7 years ago

Ahh, no. I did not. I just installed the new one, so my machine had both.

*Brian

On Wed, Mar 8, 2017 at 9:09 PM, lstandage notifications@github.com wrote:

Did you remove the previous compiler version?

On Mar 8, 2017 11:33 AM, "Brian Schmalz" notifications@github.com wrote:

Interesting - I'm still using plugin version 0.9.9, and with the new compiler, (1.43 RC1) I had no trouble importing or building a sketch.

Hmmm.

*Brian

On Wed, Mar 8, 2017 at 12:08 PM, guymc notifications@github.com wrote:

Uploading now, will appear here in about 5 minutes:

https://microchip.box.com/s/3rtrjbct27femocf6xyvfdsjxp633xrs

Guy

From: Brian Schmalz [mailto:notifications@github.com] Sent: Wednesday, March 08, 2017 10:59 AM To: chipKIT32/chipKIT-importer Cc: Subscribed Subject: Re: [chipKIT32/chipKIT-importer] Compiler requirement tied to test candidate version (#10)

Do we have a link for the new RC compiler?

Brian

On Mar 8, 2017 11:57 AM, "Grzegorz Hołdys" <notifications@github.com< mailto:notifications@github.com>> wrote:

Fixed with version 0.9.11. Please verify.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10# issuecomment-285116760, or mute the thread https://github.com/notifications/unsubscribe- auth/AAbeCP8nnt3g-AXXUfhnPB1-8Qw-H2sBks5rjuvvgaJpZM4MXGLS .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ chipKIT32/chipKIT-importer/issues/10#issuecomment-285117214, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ AArtqqNcJA76p2VYrMlNQHKjI2nmzfcpks5rjuxLgaJpZM4MXGLS.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10# issuecomment-285119865, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCG- G2ANsrqhup8WrIysu7Iu5dvBjks5rju6GgaJpZM4MXGLS .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10# issuecomment-285127012, or mute the thread https://github.com/notifications/unsubscribe-auth/ALyFRThu-glwfiiWI1wb- PnTKxNgFKlhks5rjvSLgaJpZM4MXGLS .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-importer/issues/10#issuecomment-285241951, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCC4-Ra40WRkCmmMi6uzBju--rapdks5rj21dgaJpZM4MXGLS .

lstandage commented 7 years ago

The plugin now does work with the new compiler.

But a question.

From the code, it looks like the importer is checking the path of the compiler to see whether it is the correct version. Will this handle future versions of the compiler, say, 1.44?

How will it handle situations where the user has installed the compiler in a different directory than the default?

Not that we can cover all situations, but I wonder if we can get the version directly from the compiler itself.

Finally, how do we tell which compiler is valid? I think the problem I had earlier today was because MPLAB X had a v1.43-TC5 in its tools list, but it wasn't actually on the computer. Can we test the compiler before selecting it, or can MPLAB X tell us that there may be a problem with that tool?

lstandage commented 7 years ago

Marking fixed unless proven otherwise.