search

chipbennett / oenology

WordPress Theme Oenology
62 stars 10 forks source link

Undefined index: display_social_icons #144

Closed chipbennett closed 8 years ago

chipbennett commented 8 years ago

Option removed here:

https://github.com/chipbennett/oenology/commit/acf3b45e74f88b2eaea146f225d7f5d8e20a3062

But still being used in a conditional. Restore the option.

Support forum reference:

https://wordpress.org/support/topic/theme-has-notice?replies=2

Props: @tenman

chipbennett commented 8 years ago

I'm really not liking the implementation with the core checkbox control, because the core control doesn't output a setting title for checkboxes. I could write a custom control, but that seems silly/overkill. Maybe a better implementation would be to remove the option, output the social icons by default, and make it filterable. The template hook is already in place, to be used: oenology_hook_sidebars_top.