chipmuenk / pyfda

Python Filter Design Analysis Tool
http://chipmuenk.github.io/
MIT License
649 stars 93 forks source link

passing parameter for Kaiser Window #155

Closed bhmercier closed 5 years ago

bhmercier commented 5 years ago

How to pass parameter (beta) for Kaiser windowing? Without it, I get the error: [filter_factory.py:234] ErrCode 99: Method 'LPmin' of class 'Firwin': The 'kaiser' window needs one or more parameters -- pass a tuple.

chipmuenk commented 5 years ago

How are you trying to design the filter? Do you use pyFDA with the GUI or are you using the filter design routines in your own software?

When designing a filter in the GUI this error shouldn't happen - which is your pyfda version?

bhmercier commented 5 years ago

Hello, I use pyfda in the GUI. My version is 0.1.5. All other windows are working, but the Kaiser one requires a parameter (I guess it is the beta value), and I don't know how to pass it.

chipmuenk commented 5 years ago

Hm, I'm sorry - I guess you found a bug in 0.1.5 that I must have fixed in the 0.2 branch at some point ... and yes, it's the beta value. I'll finally release version 0.2 next week, please have some patience till then!

Am 18.10.19 um 19:34 schrieb bhmercier:

Hello, I use pyfda in the GUI. My version is 0.1.5. All other windows are working, but the Kaiser one requires a parameter (I guess it is the beta value), and I don't know how to pass it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipmuenk/pyfda/issues/155?email_source=notifications&email_token=ABDH55HRDI4ERFUKUN6IGZTQPHXS7A5CNFSM4JBZYTQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBVIQIY#issuecomment-543852579, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDH55G4BZIIGKHFC42HU6TQPHXS7ANCNFSM4JBZYTQQ.

bhmercier commented 5 years ago

Christian, thanks for your prompt answer. I think you will easily correct this bug! Cheers. Bernard

bhmercier commented 5 years ago

Hi Christian, In fact the same issue exists each time one ore parameter is needed, namely for the following windows:

chipmuenk commented 5 years ago

Thanks once more for reporting, please try the new and shiny version 0.2.