chipmuenk / pyfda

Python Filter Design Analysis Tool
http://chipmuenk.github.io/
MIT License
655 stars 94 forks source link

Trivial poles and zeros displayed as 0+1j in cell in P/Z tab #231

Closed tspiteri closed 1 year ago

tspiteri commented 1 year ago

If I design an FIR filter all its poles are 0, and are shown properly in the P/Z diagram. However, on the tab where you can edit poles and zeros they are displayed as 0+1j.

Editing a pole and setting it to 0 will result in it being displayed as 0+1j in its cell, though it will still be treated correctly as 0 everywhere else. The same goes for zeros: setting the cell for a zero to 0 will result in it being displayed as 0+1j in its cell, though the zero on the P/Z diagram is correctly on the origin.

This is for version 0.7.1.

tspiteri commented 1 year ago

I just found out this is already fixed by 36dcf471b4c5d88f5f54099ee3bc5f247e2774c8 in the develop branch.