Closed XiangyuG closed 4 years ago
Few things to check
@anirudhSK What do you think?
Or
Cherry-picking commits from chipmunk-tofino should be done in separate PR(s).
I don't know how you generated those so many "Merge branch 'master' of https://github.com/chipmunk-project/chipmunk" commits with zero diffs, consider dropping them using https://stackoverflow.com/a/1338758.
For the last commit, 26659ed, update the commit message appropriately. $> git commit --amend
@taegyunkim: Thanks for noticing that the AppVeyor build wasn't running. I tried getting AppVeyor to work a few times, but I think some configuration setting (either on GitHub or AppVeyor) is causing AppVeyor builds to not be triggered.
GitHub Actions might be a better choice (#195) because it involves much less cross-app configuration and authentication.
About the merge commits, let's let them be. Eventually, it all turns into one single commit on master anyway. It's more important that that single commit is readable and passes tests.
About cherry-picking commits from the other repo, let's figure out how to do it most efficiently when we next meet.
@XiangyuG: Once we merge #195, let's redo the current PR on top of the new master.
Now, we can add more parameters through cmd line to specify the input packet fields and our spec assert for slicing.