chipsalliance / Caliptra

Caliptra IP and firmware for integrated Root of Trust block
Apache License 2.0
116 stars 28 forks source link

Doc inconsistency in UDS vs UDS seed #191

Open varuns-nvidia opened 4 months ago

varuns-nvidia commented 4 months ago

Should consistently refer to UDS as the output of de-obfuscation and UDS seed as the input. @FerralCoder , @bluegate010 for thoughts before we jump on this.

FerralCoder commented 4 months ago

I would agree with that suggestion. @JohnTraverAmd do you agree as well? I do think that we should always refer to the fused value as UDS Seed, and only the value after de-obfuscation as UDS.

That said, the UDS Seed itself should still be generated following rules for generating a NIST compliant UDS.

JohnTraverAmd commented 3 months ago

I think that the input to the obfuscation should be called obfuscated UDS while the output is called UDS. UDS Seed may not make sense at this point. What is the point of creating a term for UDS-Seed? I think that if anything, we are creating an IDevID Seed.

bharatpillilli commented 4 weeks ago

If we call it obfuscated UDS, someone will ask how is Caliptra or manufacturing obfuscating the value (infact some folks were already asking this when we stated UDS deobfuscation). So it is better to keep it as UDS seed IMHO.