chipsalliance / Cores-VeeR-EH1

VeeR EH1 core
Apache License 2.0
802 stars 217 forks source link

fpga_optimize cannot be set to 0 in swerv_config #100

Open jlucnagel opened 3 years ago

jlucnagel commented 3 years ago

Hi, fpga_optimize defaults to 1 and it cannot be set to 0 on the command line (cannot receive a parameter and if not defined will be set to default value 1 !). If this value shall never be set to 0, it should be removed from script. Otherwise the script should allow to pass 0 as a parameter (fairly minor fix). Thanks, Jean-Luc

diff --git a/configs/swerv.config b/configs/swerv.config index 798eb14..27c998c 100755 --- a/configs/swerv.config +++ b/configs/swerv.config @@ -207,7 +207,7 @@ "pic_total_int=s" => \$pic_total_int, "icache_size=s" => \$icache_size, "ahb_lite" => \$ahb_lite,

aprnath commented 3 years ago

It can be set to 0 via -set=fpga_optimize=0