chipsalliance / Cores-VeeR-EH1

VeeR EH1 core
Apache License 2.0
818 stars 221 forks source link

typo in swerv.config #70

Closed sobuch closed 4 years ago

sobuch commented 4 years ago

In https://github.com/chipsalliance/Cores-SweRV/blob/master/configs/swerv.config#L1914

 $jh{memmap}{cosnoleio} = $config{memmap}{serialio} if exists $config{memmap}{serialio};

I suppose it should be: cosnoleio -> consoleio

aprnath commented 4 years ago

Thanks for reporting. Note that this is only used by the testbench, and not the design itself. Will be fixed in next release.

sobuch commented 4 years ago

I see this changed in the new version, however it still doesn't work for me.

Currently, there is the following at https://github.com/chipsalliance/Cores-SweRV/blob/master/configs/swerv.config#L1962:

    foreach my $tag (qw ( size page_size serialio )) {
        $jh{memmap}{tag} = $config{memmap}{ta} if exists $config{memmap}{tag};
    }

Could it be more like this?

    $config{memmap}{consoleio} = $config{memmap}{serialio} if exists $config{memmap}{serialio};

    foreach my $tag (qw ( size page_size serialio consoleio)) {
        $jh{memmap}{$tag} = $config{memmap}{$tag} if exists $config{memmap}{$tag};
    }
aprnath commented 4 years ago

Indeed. Good catch Sam.

sobuch commented 4 years ago

I can confirm its fine now, thus closing this issue. Thank you for looking into this.