chipsalliance / Cores-VeeR-EH1

VeeR EH1 core
Apache License 2.0
822 stars 221 forks source link

Fix FuseSoC config generator #94

Closed joannabrozek closed 3 years ago

joannabrozek commented 3 years ago

After the following change: https://github.com/chipsalliance/Cores-SweRV/commit/ec254f5#diff-7682db868261ad0b18c9d5ca090189ad3eac89bbbcbc44530c9b2a40ee71a6eaL37 the FuseSoC tool started failing due to a missing directory and this commit fixes it.

agrobman commented 3 years ago

Joanna, the swerv.config generates files in current directory now: $PWD/snapshots/ by default. (Not in $RV_ROOT/configs/snapshots/..).

joannabrozek commented 3 years ago

@agrobman, I changed the directory according to the default build directory as you said. I just want to fix FuseSoC tool to get dependency list.

olofk commented 3 years ago

Thanks for reporting. I see what happened now. When the code dump for version 1.9 was commited it overwrote swerv_config_gen.py with an older version. I think restoring the version from before the 1.9 release is the proper fix.

olofk commented 3 years ago

To be explicit, this is the version we want https://github.com/chipsalliance/Cores-SweRV/blob/7332edc0adaa7e9a0c842d169154429e8d987786/configs/swerv_config_gen.py

aprnath commented 3 years ago

Thanks Olof. I have reverted to that commit (0242c9e). Please confirm.

olofk commented 3 years ago

Yes! That is correct. Thanks. If this works for @joannabrozek too I think we can close the issue

aprnath commented 3 years ago

Thanks Olof. Hi Joanna, please use this latest commit and see if it works for you.

joannabrozek commented 3 years ago

Yes, It works. Thanks a lot for help.