When running the veer config script as defined in the readme, one of the output files is common_defines.vh. There are several potential improvements that our team requests for this generated file:
When the file is re-generated (with or without any changes to the core configuration arguments), the ordering of macros in common_defines.vh is scrambled, which makes text diffs/git changes difficult to read. Making the order consistent between re-generation would be helpful.
Protection header macros can help reduce compilation warnings due to re-definition of verilog macros. Header protection macros are implemented in the Caliptra project and may be used as reference for this request: common_defines.sv
RV_ASSERT_ON macro should be guarded by checks for SYNTHESIS and for VERILATOR as shown here
When running the veer config script as defined in the readme, one of the output files is common_defines.vh. There are several potential improvements that our team requests for this generated file: