chipsalliance / Cores-VeeR-EL2

VeeR EL2 Core
https://chipsalliance.github.io/Cores-VeeR-EL2/html/
Apache License 2.0
246 stars 74 forks source link

Request to review Lint Issues in Veer RTL #166

Open amullick007 opened 6 months ago

amullick007 commented 6 months ago

Hi, I am filling this issue to review couple of Lint issues inside Veer RTL.

  1. In el2_veer.sv file, below highlighted signals are read but never set.

    assign ifu_axi_bready_int = pt.BUILD_AHB_LITE ? ifu_axi_bready_ahb : ifu_axi_bready; assign lsu_axi_bready_int = pt.BUILD_AHB_LITE ? lsu_axi_bready_ahb : lsu_axi_bready; assign sb_axi_bready_int = pt.BUILD_AHB_LITE ? sb_axi_bready_ahb : sb_axi_bready;

  2. Output signal highlighted below is never set.

Output 'ifu_bp_fa_index_f' is never set. (veer_el2/rtl/ifu/el2_ifu_bp_ctl.sv) Output 'exu_mp_pkt.br_start_error' is never set. (veer_el2/rtl/exu/el2_exu.sv) Output 'exu_mp_pkt.br_error' is never set. (veer_el2/rtl/exu/el2_exu.sv) Output 'exu_mp_pkt.prett[31:1]' is never set. (veer_el2/rtl/exu/el2_exu.sv) Output 'lsu_ld_data_r[31:0]' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv) Output 'dccm_rdata_lo_r[31:0]' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv) Output 'dccm_rdata_hi_r[31:0]' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv) Output 'dccm_data_ecc_lo_r[6:0]' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv) Output 'dccm_data_ecc_hi_r[6:0]' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv) Output 'ic_parerr[1:0]' is never set. (veer_el2/rtl/el2_mem.sv)

Request to clean up the code to keep Lint happy.

koblonczek commented 4 months ago

Hi, could you specify what lint tool/tools you've used to generate this list of lint issues?

amullick007 commented 4 months ago

We have used Synopsys Spyglass