chipsalliance / Cores-VeeR-EL2

VeeR EL2 Core
https://chipsalliance.github.io/Cores-VeeR-EL2/html/
Apache License 2.0
243 stars 73 forks source link

Apply fixes after merging changes from caliptra-rtl #215

Closed kiryk closed 1 month ago

kiryk commented 1 month ago

This change:

  1. Removes redundant design/el2_pdef.vh file, which is generated by the flow,
  2. Makes veer.config produce parameter struct using logic type, instead of bit,
  3. Makes the RTL handle all valid ICACHE_NUM_WAYS values.
github-actions[bot] commented 1 month ago

Links to coverage and verification reports for this PR (#215) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

calebofearth commented 1 month ago

What script is responsible for generating el2_pdef.vh? An important recent change was to convert 'bit' types to 'logic' for lint cleanliness. Is that change merged to the generator script? If not, I'll request that it be added in this PR. Thanks.

kiryk commented 1 month ago

Hi @calebofearth, the script that generates el2_pdef.vh is in configs/veer.config. I just pushed the change that makes it use logic type, along with the fix of handling the general case of icache set sizes.

github-actions[bot] commented 1 month ago

Links to coverage and verification reports for this PR (#215) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

github-actions[bot] commented 1 month ago

Links to coverage and verification reports for this PR (#215) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/