Fix issue with linking dependency of -lstdc++fs when using flatpak

chipsalliance / Surelog

SystemVerilog 2017 Pre-processor, Parser, Elaborator, UHDM Compiler. Provides IEEE Design/TB C/C++ VPI and Python AST & UHDM APIs. Compiles on Linux gcc, Windows msys2-gcc & msvc, OsX

Apache License 2.0

357 stars 68 forks source link

Fix issue with linking dependency of -lstdc++fs when using flatpak #3966

Closed sebinho closed 4 months ago

sebinho commented 4 months ago

When trying to build Surelog inside a flatpak, it fails due to a linking issue with -lstdc++fs. See opened topic here: https://github.com/flathub/flathub/issues/5221

It seems to be an old legacy linking practice that should be removed or it should be able to properly detect old versions of Ubuntu that requires it.

hzeller commented 4 months ago

LGTM. Context: this was indeed a legacy leftover from the time around 2019 when compilers did not universally have the latest std::filesystem stuff (which should've been there in c++17), so shipped it as separate libraries.

Thanks for removing.