chipsalliance / VeeR-ISS

Apache License 2.0
114 stars 33 forks source link

Illegal instuction not detected as illegal in whisper #14

Closed UrvishkumarPatel closed 2 years ago

UrvishkumarPatel commented 2 years ago

Instruction 0x5036 is illegal (c.lwsp with rd=0) according to riscv specification but whisper is not decoding it as illegal.

aprnath commented 2 years ago

This was fixed in the November 15 push (9058ea5db5d)

See line https://github.com/chipsalliance/SweRV-ISS/blob/9058ea5db5d244b0e67ef7fd8afb87142b94dae8/decode.cpp#L892