search

chipsalliance / caliptra-rtl

HW Design Collateral for Caliptra RoT IP
Apache License 2.0
62 stars 34 forks source link

Lint error reported by VC spyglass #456

Open DerekWangScaleflux opened 6 months ago

DerekWangScaleflux commented 6 months ago

Hi Caliptra team, Could you help to check the following lint error reported by VC ( T-2022.06-SP2 ) ?

[155a] STARC05-2.3.6.1 N.A error /prj_wkr/quincelite/workarea/derekwang/quince_lite_0/trunk/design/Caliptra/src/pcrvault/rtl/pv_gen_hash.sv 208 N.A Uninitializable flip-flop 'nonce_offset_i' coexists with flip-flops having asynchronous reset/set description in the same block (line: 198). [Hierarchy: 'sss_top.sha512.sha512_inst.pv_gen_hash1']

[e4] UndrivenInTerm-ML N.A error /prj_wkr/quincelite/workarea/derekwang/quince_lite_0/trunk/design/Caliptra/src/riscv_core/veer_el2/rtl/el2_veer_wrapper.sv 385 10 Detected undriven input terminal rvtop/veer/ic_debug_rd_data[70:0]

[e5] UndrivenInTerm-ML N.A error /prj_wkr/quincelite/workarea/derekwang/quince_lite_0/trunk/design/Caliptra/src/riscv_core/veer_el2/rtl/ifu/el2_ifu_mem_ctl.sv 927 10 Detected undriven input terminal rvtop/veer/ifu/mem_ctl/perr_dat_ff/din[6:0]

[e7] UndrivenInTerm-ML N.A error /prj_wkr/quincelite/workarea/derekwang/quince_lite_0/trunk/design/Caliptra/src/riscv_core/veer_el2/rtl/el2_veer_wrapper.sv 388 10 Detected undriven input terminal rvtop/veer/ic_eccerr[1:0]

[e6] UndrivenInTerm-ML N.A error /prj_wkr/quincelite/workarea/derekwang/quince_lite_0/trunk/design/Caliptra/src/riscv_core/veer_el2/rtl/ifu/el2_ifu_mem_ctl.sv 1387 10 Detected undriven input terminal rvtop/veer/ifu/mem_ctl/bus_ic_wr_en[1:0]

Best Regards Derek Wang

DerekWangScaleflux commented 6 months ago

Addtional errors ( errors of W123 ) in attached file:

Caliptra_Lint_Error_W123.txt

DerekWangScaleflux commented 6 months ago

Additional error of W164a in attached file: Caliptra_LInt_Error_W164a Caliptra_Lint_Error_W164a.txt

Nitsirks commented 5 months ago

There are open issues for lint errors, we are aware of them and in the process of providing a fix.

DerekWangScaleflux commented 5 months ago

There are open issues for lint errors, we are aware of them and in the process of providing a fix.

Thanks. Could you kindly provide a due time please ?

DerekWangScaleflux commented 5 months ago

Hi Caliptra team, Any updates ?

Best Regards Derek Wang

Nitsirks commented 5 months ago

We are still working on this, no eta at this time.

DerekWangScaleflux commented 5 months ago

Hi, @Nitsirks , Any updates ?

 And could you help to check the following lint warnings also ?

Caliptra_Lint_ResetFlop-ML.txt Caliptra_Lint_STARC05-1.3.1.3.txt

Best Regards Derek Wang

Nitsirks commented 5 months ago

This PR is going through testing. Resolves most of the issues that we are seeing from partners.

https://github.com/chipsalliance/caliptra-rtl/pull/483

ResetFlop-ML and STARC05-1.3.1.3 are not rules that we have enabled at this time.

DerekWangScaleflux commented 5 months ago

Hi, @Nitsirks Pls kindly inform me when this is completed. We are close to RTL freeze now.

Best Regards Derek Wang

calebofearth commented 4 months ago

483 has been merged

DerekWangScaleflux commented 3 months ago

483 has been merged

Hi @calebofearth , Is there must fix lint issue in this merge ?

Best Regards Derek Wang

Nitsirks commented 3 months ago

Lint should be clean to our ruleset as of #483 If you are seeing lint errors, they may need to be waived.