search

chipsalliance / caliptra-rtl

HW Design Collateral for Caliptra RoT IP
Apache License 2.0
75 stars 38 forks source link

Package Macro potential issue #591

Open nikola-kovacevic-ns opened 2 months ago

nikola-kovacevic-ns commented 2 months ago

Hello,

Caliptra in package definitions has following macro:

`ifndef PRIM_ASSERT
`define CALIPTRA_PRIM_ASSERT

Is this intentional? Shouldn't it be like this:

`ifndef CALIPTRA_PRIM_ASSERT
`define CALIPTRA_PRIM_ASSERT

It is causing problems when integrating caliptra with other cores wich have the same lowrisc ibex base RTL code.

Thanks in advance, Kovacevic Nikola

calebofearth commented 2 months ago

Hi, this is a duplicate of https://github.com/chipsalliance/caliptra-rtl/issues/332, which is a follow-up from https://github.com/chipsalliance/caliptra-rtl/issues/56. This is intended to be exclusively a reference to CALIPTRA_PRIM_ASSERT as you pointed out and will be fixed for the 2.0 release.