search

chipsalliance / caliptra-sw

Caliptra software (ROM, FMC, runtime firmware), and libraries/tools needed to build and test
Apache License 2.0
48 stars 35 forks source link

ECC Driver does not check error regs #1598

Open nquarton opened 4 days ago

nquarton commented 4 days ago

The ECC driver does not check error_global_intr_r or error_internal_intr_r. These should be checked anywhere we wait on ecc_status.valid since valid will not be set in the error case. Without this check, the ROM/FW will hang if an error is encountered.

This was noticed when forcing the public key to a bad value to cause the pairwise consistency check to fail for the FIPS tests.

jhand2 commented 2 days ago

Agreed that we should fix this. I don't think there's a way for anyone other than the vendor to force this behavior in ROM (public keys must be fused in the manifest), but I think it can be forced in RT via the mailbox verify command.