Open jackkoenig opened 2 months ago
What's weird is that these failing tests are currently printing failures and maybe even crashing on main, but for some reason SVSim returns success. I think my changes are just exposing some other underlying issue. I had been planning to revisit how we deal with $stop
in a follow on PR, but it might just have to be done in this PR as well.
Thanks for the review @dobios! I think I sadly have to bite the bullet and also implement $stop
for this to pass CI... will revisit eventually 😭
This is a bugfix but I'm not sure if it should be backported [yet] because adding new arguments, even with default arguments, to public methods breaks binary compatibility. I don't feel like dealing with that at the moment. If we need to backport it later, we can. We could backport just the bugfix part of it I guess.
The returned exception is now a lot more elegant than
svsim.Simulation.UnexpectedEndOfMessages
. This also fixes an issue where the Verilator crashes could create core dumps depending on the user's ulimit settings.I have not yet tested this with VCS, so there may be follow up work (possibly in a follow up PR).
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.