search

chipsalliance / dromajo

RISC-V RV64GC emulator designed for RTL co-simulation
Apache License 2.0
210 stars 63 forks source link

Change build system to CMake. #29

Closed sequencer closed 4 years ago

sequencer commented 4 years ago

To make build system more strandard and friendly, this PR changes original makefile to CMake for better integration between different projects. Hope it can get merged.

et-tommythorn commented 4 years ago

Thanks for the patch and apologies for late response, but we were debating this and it's impact. Dromajo is generally integrated into other projects as much as used stand-alone, so not all the impact in visible from the repo. However, it's a nice clean up and we'll take it with some caveats:

  1. the docs/*md needs to be patched (../src/ should be changed to ../build/
  2. The cmake_minimum_required is set much too high; CentOS 7 (yes, ancient, but this is the EDA world for you) doesn't appear to have newer than version 2.8.12.2. Is there a good reason for requiring anything newer?

Unfortunately, the most recent commit broke dromajo on CentOS 7. I can pull in this on top, but I hesitate adding changes to a broken tree.

et-tommythorn commented 4 years ago

I'll pull this and fix the other issue subsequently.

sequencer commented 4 years ago

Oh! So sorry for my delay, I totally missed this! I was working on the Scala stuffs yesterday.