chipsalliance / dromajo

RISC-V RV64GC emulator designed for RTL co-simulation
Apache License 2.0
213 stars 63 forks source link

Update for Cosimulation (Parameter Overrides + Misc. Cleanup) #3

Closed abejgonzalez closed 4 years ago

abejgonzalez commented 4 years ago

Related Issues/PRs: https://github.com/riscv-boom/riscv-boom/pull/415 https://github.com/abejgonzalez/dromajo/pull/1

Release Notes: This PR is all the changes that BOOM (boom-core.org) has done in order to cosimulate using Dromajo. Here is a high-level list of all the changes:

Any recommendations/concerns are welcome!

et-tommythorn commented 4 years ago

That looks great. Let me comb it over tomorrow before merging. Thanks for the improvement.

et-tommythorn commented 4 years ago

Ok, I resolved conflicts, squashed, and pushed.

Next time, please make sure that it's rebased on the current master before submitting a request. Also, do squash all changes unless there a very good reason for individual commits. Finally, no merge commits, thanks.

abejgonzalez commented 4 years ago

Sorry about that, bad habit. Also, I didn't know what the strategy was for doing PRs (rebase or merge commit) so I left that alone for now. In any case, thanks for the review/feedback!

et-tommythorn commented 4 years ago

No problem; I was merely providing the requested feedback. The rebase vs. merges is largely an question of taste (good taste and bad taste :)