Post-CMake fixes - Githubissues

chipsalliance / dromajo

RISC-V RV64GC emulator designed for RTL co-simulation

Apache License 2.0

213 stars 63 forks source link

Post-CMake fixes #31

Closed et-tommythorn closed 4 years ago

et-tommythorn commented 4 years ago

The Copyright notice was left out
Important build flags were left out
The cmake_minimum_required were set much too high; CentOS 7 doesn't appear to have newer than version 2.8.12.2 and there doesn't appear to a reason for requiring anything newer.
The docs/*md needed to be patched to account for the src -> build change

et-tommythorn commented 4 years ago

I've never used cmake before and I didn't check if there's a better way to add the compilation options, but absolute have to be there. CentOS 7 compatibility is a hard requirement and it uses ... gasp ... gcc 4.8.5. Please let me know if I can do this better.

sequencer commented 4 years ago

I'm not sure if CentOS is OK with this changing. Hmmm, 4.8 was really old release.

et-tommythorn commented 4 years ago

I'm not seeing a better solution and as the build is currently broken on CentOS 7 I'll go ahead merge this. Improvements are welcome later.