tommythorn
commented
3 years ago It's a placeholder to disable the conditional with a single character change, but I should have removed it. I'll fix both.
Tommy
On Thu, Sep 17, 2020 at 11:55 PM Jose Renau notifications@github.com wrote:
@renau commented on this pull request.
In src/dw_apb_uart.cpp https://github.com/chipsalliance/dromajo/pull/32#discussion_r490739743:
@@ -181,20 +183,22 @@ void dw_apb_uart_write(void *opaque, uint32_t offset, uint32_t val, int size_log
assert(offset % 4 == 0 && offset / 4 < 64);
- if (reg_names[offset / 4] && size_log2 == 2)
- DEBUG("dw_apb_uart_write(0x%02x \"%s\", %d)\n", offset, reg_names[offset / 4], val);
- if (1 && offset == 0)
This is a bit strange if (true and offset==0) should be the same as if (offset==0)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chipsalliance/dromajo/pull/32#pullrequestreview-491195589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSTGELTC3FSTCNNJ44TWTSGL74XANCNFSM4RRHBOJA .
Misc accumulated improvements. Officially deprecates reliance on the auto generated bootrom and include a simple example of make to make one + adds support for giving it in the config file.
META COMMENT: please do not add command line options without a corresponding option for the config file, unless inappropriate. Dromajo has a fair amount of technical debt, but piling on my command line options is the wrong direction. We need to refactor it further to where it can be included as a library.