et-tommythorn
commented
3 years ago Ignoring the code style issues
add flag to clear mimpid, marchid, mvendorid is fine, but it adds to the proliferation of command line arguments and doesn't leave a way to set it up in the .cfg file.
[cosim] add memory override hook and [cosim] add func proto and clean up are fine.
print all Nope, not ok.
match rc interrupts is tricky, getting this right for Maxion cosimulation was difficult and I think this breaks it.
However the interrupt priority fix is great. I'm sure we got that wrong but never hit it. We can accept this, but might have to visit this.
properly parse the memory size and extra debugging sure
fix strtok seg. fault errors by duplicating str in args ok (strangely explicitly break the coding style)
I'll push with the fixes.
Bring the latest changes from Berkeley fork. Now, maybe they can pull latest updates (trying not to diverge)