Closed sinofp closed 3 years ago
To easy the review, please provide the methodology that you refactor(like gathering those files) in the next time. This makes code refactoring reproducible.
Here is my method:
os.walk(os.pwd / "examples").filter(os.isFile).groupBy(os.read).filter(_._2.length > 1).values
You can find all files which can be safely removed with:
os.walk(os.pwd / "examples").filter(os.isFile).groupBy(os.read).filter(_._2.length > 1).values.map(_.drop(1)).flatten
Here is my result:
espresso/examples/examples/signet espresso/examples/examples/mainpla espresso/examples/examples/jbp espresso/examples/examples/misg espresso/examples/tlex/ex5.pla espresso/examples/examples/x7dn espresso/examples/examples/ts10 espresso/examples/tlex/cps.pla espresso/examples/examples/soar.pla espresso/examples/tlex/spla.pla espresso/examples/examples/b9 espresso/examples/examples/ibm espresso/examples/examples/x2dn espresso/examples/examples/pdc espresso/examples/tlex/pdc.pla espresso/examples/tlex/inc.pla espresso/examples/examples/xparc espresso/examples/examples/ex4 espresso/examples/tlex/ex4.pla espresso/examples/examples/b7 espresso/examples/examples/shift espresso/examples/examples/mish espresso/examples/tlex/b12.pla espresso/examples/examples/ex1010 espresso/examples/tlex/ex1010.pla espresso/examples/examples/ti espresso/examples/examples/misj
I found you removed 27 files too, so I believe you are doing a reasonable refactor.
To easy the review, please provide the methodology that you refactor(like gathering those files) in the next time. This makes code refactoring reproducible.
Here is my method:
You can find all files which can be safely removed with:
Here is my result:
I found you removed 27 files too, so I believe you are doing a reasonable refactor.