chipsalliance / f4pga-examples

Example designs showing different ways to use F4PGA toolchains.
https://f4pga-examples.readthedocs.io
Apache License 2.0
264 stars 77 forks source link

Modify requirements.txt to accomodate changes in fasm #124

Open Mattia9875 opened 3 years ago

Mattia9875 commented 3 years ago

In xc7/requirements.txt substitute git+https://github.com/symbiflow/fasm with --no-use-pep517 git+https://github.com/SymbiFlow/fasm.git#egg=fasm

as of issue over on /symbiflow/fasm

mentioning this because the issue causes conda to fail the env creation process, rendering the image in a docker enviroment unbuildable

litghost commented 3 years ago

Now that fasm is on PyPi, the xc7/requirements can just remove the fasm requirement completely now that it is in PyPi.

Mattia9875 commented 3 years ago

You mean that in the sense that i could do it on my system? or that is the general way to fix it?

litghost commented 3 years ago

You mean that in the sense that i could do it on my system? or that is the general way to fix it?

As in you/I could submit a PR to fix this?

Mattia9875 commented 3 years ago

Yes, though Tim responded on the issue I cited saying that he is currently working on in so I don't know how this issue will stand