chipsalliance / f4pga-examples

Example designs showing different ways to use F4PGA toolchains.
https://f4pga-examples.readthedocs.io
Apache License 2.0
263 stars 77 forks source link

Symbiflow-classroom: "Multiple include causes error" #265

Open nelsobe opened 2 years ago

nelsobe commented 2 years ago

SYMBIFLOW-CLASSROOM-PROJECT

Using the include macro to include the same module more than once in a project (perhaps from different locations in the files) causes an error. While bad practice, this causes an error for the tools while Vivado just redefines the module.

nelsobe commented 2 years ago

@mithro @acomodi @tmichalak @mkurc-ant Would be interested in any feedback you can provide.

rkapuscik commented 2 years ago

Could you specify the tool you're using and the exact error?

I've created this test. It does fail in Yosys with Verilog frontend, but passes in UHDM frontend. I tested it also in Surelog and Verilator and they issue only a warning in this case.

nelsobe commented 2 years ago

Using original Yosys frontend.