chipsalliance / f4pga-examples

Example designs showing different ways to use F4PGA toolchains.
https://f4pga-examples.readthedocs.io
Apache License 2.0
267 stars 77 forks source link

Flow continues with Undefined Type Error using Surelog #309

Closed westonMS closed 2 years ago

westonMS commented 2 years ago

Issue

When declaring an invalid type the Surelog parser gives the following error: [ERR:CP0317] {PATH}/top.sv:2: Undefined type "param".

Despite this error being identified, the flow continues to the end until a bitstream is generated.

The default yosys parser catches this and gives: ERROR: syntax error, unexpected '=', expecting '(' or '['.

Code Example

module top(output logic outLED);
sandwich TEST_PARAM = "TestParam.txt";
assign outLED = 1;
endmodule
rkapuscik commented 2 years ago

This should be already fixed with https://github.com/chipsalliance/yosys-f4pga-plugins/pull/301, but it seems that the tools in this repository were not updated yet.

jcrob2 commented 2 years ago

Using the following timestamp and hash, the issue still exists. Timestamp: 20220606-234655 Hash: 1667c14

I've included a file that contains a list of the content/versions of the conda environment that we have. conda_list.txt

rkapuscik commented 2 years ago

This should be already fixed, please update the plugin to the newest version as described here to verify.

westonMS commented 2 years ago

I've retested this with the latest install and have verified that it works