chipsalliance / f4pga-v2x

Tool for converting specialized annotated Verilog models into XML needed for Verilog to Routing flow.
https://f4pga-v2x.readthedocs.io/en/latest/
Apache License 2.0
10 stars 12 forks source link

Support for clock buffer/mux modeling #74

Closed mkurc-ant closed 4 years ago

mkurc-ant commented 4 years ago

This PR adds a feature that allows to model clock buffers and multiplexers in V2X.

mithro commented 4 years ago

@mkurc-ant -- Recently when looking at the SDC parsing stuff I came across a document from Xilinx which describes how various values can be set using verilog attributes / properties. These seem a lot like the type of things we need in v2x, so I copied them to the spreadsheet https://docs.google.com/spreadsheets/d/1G-E2Dq8YG4g9Z6mTygpumwlI_vNlFUQinc9gMgePfec/edit#gid=1349094793

Could you take a look over these values and see if any of these match enough that we should be using them instead?

mkurc-ant commented 4 years ago

@mithro I've gone through them. In my opinion for now only the (* clock_signal = "{yes|no}" *) matches the CLOCK attribute currently implemented in V2X.

We basically need most of the attributes to control XML generation an it is loosely coupled with actual synthesis/implementation control.

mkurc-ant commented 4 years ago

Requires https://github.com/SymbiFlow/python-symbiflow-v2x/pull/76 for the CI to pass.

mithro commented 4 years ago

@mkurc-ant - I think we can probably merge this after the docs update?

mkurc-ant commented 4 years ago

@mithro Yes. Once docs update is merged I'll add docs to this one.

mkurc-ant commented 4 years ago

@mithro I've rebased and updated docs.

mkurc-ant commented 4 years ago

@mithro I've incorporated your requested changes. Could you re-review?

mkurc-ant commented 4 years ago

@mithro Do you have any other questions to this PR or can we merge it?

mithro commented 4 years ago

Please update the pull request comment and then feel free to merge.

mithro commented 4 years ago

S/comment/description/