mithro
commented
3 years ago Notes from @litghost ;
https://github.com/SymbiFlow/fasm/pull/48/files#r571089908
https://docs.microsoft.com/en-us/cpp/build/reference/compiler-options?view=msvc-160
https://github.com/SymbiFlow/fasm/pull/48/files#r571092177
https://en.cppreference.com/w/cpp/language/attributes/fallthrough
If ANTLR could emit
[[fallthrough]],-Wimplicit-fallthrough=0is not required.
https://github.com/SymbiFlow/fasm/pull/48/files#r571093017
PIC support might be possible via: https://cmake.org/cmake/help/v3.0/prop_tgt/POSITION_INDEPENDENT_CODE.html
https://cmake.org/cmake/help/latest/module/CheckPIESupported.html#module:CheckPIESupported
https://github.com/SymbiFlow/fasm/pull/48/files#r571097079
CMake has explicit C++ standard select support: https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html
GitHub
This pull request will add a GitHub Action which builds the fasm packages, including binary wheels for Linux, Mac and Windows and then upload them to PyPI. WIP -- TODO; Have auto-incrementing ver...
Learn more about: Compiler Options
This pull request will add a GitHub Action which builds the fasm packages, including binary wheels for Linux, Mac and Windows and then upload them to PyPI. WIP -- TODO; Have auto-incrementing ver...
This pull request will add a GitHub Action which builds the fasm packages, including binary wheels for Linux, Mac and Windows and then upload them to PyPI. WIP -- TODO; Have auto-incrementing ver...
This pull request will add a GitHub Action which builds the fasm packages, including binary wheels for Linux, Mac and Windows and then upload them to PyPI. WIP -- TODO; Have auto-incrementing ver...
The cmake file needs some improvement.
It should add;
-Wimplicit-fallthrough=0if it is supported on non-Windows-Wno-attributesif it is supported on non-Windows/std:c++lateston Windows.This is related to #50.
Originally posted by @mithro in https://github.com/SymbiFlow/fasm/pull/48#r570760958