search

chipsalliance / fasm

FPGA Assembly (FASM) Parser and Generator
https://fasm.readthedocs.io
Apache License 2.0
90 stars 30 forks source link

Cleanup requirements a little and remove setup.cfg file. #64

Open mithro opened 3 years ago

mithro commented 3 years ago

setup_requires needs to be specified in both setup.py and pyproject.toml.

The requirements.txt file should use -e . to install the module (and thus get the requirements). If a local or non-PyPi version of a module should be used to satisfy a requirement for either setup_requires or install_requires then it should also be specified in the requirements.txt file.

Using setup.py is much clearer than setup.cfg and it looks like the file is going to get replaced by pyproject.toml in the future, see https://github.com/pypa/setuptools/issues/1688

Signed-off-by: Tim 'mithro' Ansell me@mith.ro

graingert commented 3 years ago

setup.py is not recommended. While pyproject.toml is preferred to setup.cfg, setup.cfg is still preferred to setup.py:

https://setuptools.readthedocs.io/en/latest/userguide/quickstart.html#transitioning-from-setup-py-to-setup-cfg

setuptools Quickstart — setuptools 54.0.0 documentation