Add support for Apple Silicon

[meme]

Fixes #10 and #11

• [x] Tests pass
• [x] Appropriate changes to README are included in PR

This PR:

• Updates Verible
• Adds support for Apple Silicon
• Updates the README to reference Chips Alliance

[meme]

/cc @hzeller @johanvdhaegen

[rkshthrmsh]

When might this be merged?

[thuvasooriya]

Please merge this branch. @hzeller @johanvdhaegen

[hzeller]

Oh, sorry, I have not seen this before.

[thuvasooriya]

==> Downloading https://formulae.brew.sh/api/formula.jws.json
######################################################################## 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json
######################################################################## 100.0%
==> Fetching chipsalliance/verible/verible
==> Cloning https://github.com/chipsalliance/verible.git
Updating /Users/tony/Library/Caches/Homebrew/verible--git
==> Checking out tag v0.0-2206-g88515c17
HEAD is now at 88515c17 Merge pull request #1401 from hzeller/20220822-use-fallback-clang-tidy
HEAD is now at 88515c17 Merge pull request #1401 from hzeller/20220822-use-fallback-clang-tidy
==> Installing verible from chipsalliance/verible
==> bazel build --jobs=8 --compilation_mode=opt --copt=-mcpu=apple-m1 --linkopt=-Wl,-rpath,@loader_path/../lib --verbose_failures //verilog/
Last 15 lines from /Users/tony/Library/Logs/Homebrew/verible/01.bazel:
Analyzing: 1398 targets (10 packages loaded, 0 targets configured)
Analyzing: 1398 targets (13 packages loaded, 4 targets configured)
Analyzing: 1398 targets (51 packages loaded, 477 targets configured)
Analyzing: 1398 targets (52 packages loaded, 477 targets configured)
ERROR: /private/tmp/verible-20230303-37918-smxkgx/.brew_home/_bazel/e90e159bf22c92cbac1ddcb9dfa7b5dd/external/bazel_tools/platforms/BUILD:89:6: in alias rule @bazel_tools//platforms:windows: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or preferably declare dependency on https://github.com/bazelbuild/platforms. See https://github.com/bazelbuild/bazel/issues/8622 for details.
ERROR: /private/tmp/verible-20230303-37918-smxkgx/.brew_home/_bazel/e90e159bf22c92cbac1ddcb9dfa7b5dd/external/bazel_tools/platforms/BUILD:89:6: Analysis of target '@bazel_tools//platforms:windows' failed
INFO: Repository python_six instantiated at:
  /private/tmp/verible-20230303-37918-smxkgx/WORKSPACE:185:13: in <toplevel>
Repository rule http_archive defined at:
  /private/tmp/verible-20230303-37918-smxkgx/.brew_home/_bazel/e90e159bf22c92cbac1ddcb9dfa7b5dd/external/bazel_tools/tools/build_defs/repo/http.bzl:372:31: in <toplevel>
ERROR: /private/tmp/verible-20230303-37918-smxkgx/verilog/tools/syntax/export_json_examples/BUILD:17:8: While resolving toolchains for target //verilog/tools/syntax/export_json_examples:verible_verilog_syntax_py_test: invalid registered toolchain '@bazel_skylib//toolchains/unittest:cmd_toolchain':
ERROR: Analysis of target '//verilog/tools/syntax/export_json_examples:verible_verilog_syntax_py_test' failed; build aborted:
INFO: Elapsed time: 16.830s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (60 packages loaded, 933 targets configured)

If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/chipsalliance/homebrew-verible/issues

Using Homebrew on M1 Macbook Air gives this error. on Ventura 13.2.1

[hzeller]

If this is running bazel 6, this might be due to an old dependency which has been fixed in the meantime.

https://github.com/chipsalliance/verible/releases/tag/v0.0-3007-g4437c436

Might be worthwhile to update as version here is about 800 commits behind. v0.0-2206

[rkshthrmsh]

@hzeller, @thuvasooriya I don't see a tap for Verible on brew. Is building from source the right way of getting verible working on Apple silicon?

I tried:

brew install verible

[hzeller]

I personally don't have access to a Mac or know much of what it takes to bring it into the brew infrastructure. Maybe you can help out ?

[thuvasooriya]

@hzeller, @thuvasooriya I don't see a tap for Verible on brew. Is building from source the right way of getting verible working on Apple silicon?

I tried:

brew install verible

I’m confused. Have you tried the instruction on the readme?

brew tap chipsalliance/verible
brew install verible

[rkshthrmsh]

Hi @thuvasooriya, although I'm able to access the tap now, the installation fails with:

Last 15 lines from /Users/rkshthrmsh/Library/Logs/Homebrew/verible/01.bazel:
  (cd /private/tmp/verible-20230307-19543-eqg5rd/.brew_home/_bazel/bea636bc4a43e72c8a9a9b8346dbe25c/sandbox/processwrapper-sandbox/11/execroot/com_google_verible && \
  exec env - \
    PATH=/opt/homebrew/Library/Homebrew/shims/mac/super:/opt/homebrew/opt/bazel/bin:/usr/bin:/bin:/usr/sbin:/sbin \
    PWD=/proc/self/cwd \
  external/local_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections -MD -MF bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2/_objs/bison_lib/InadequacyList.d '-frandom-seed=bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2/_objs/bison_lib/InadequacyList.o' '-DBAZEL_CURRENT_REPOSITORY="bison_v3.3.2"' -iquote external/bison_v3.3.2 -iquote bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2 -Ibazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2/_virtual_includes/bison_lib -isystem external/bison_v3.3.2 -isystem bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2 -isystem external/bison_v3.3.2/bison-lib -isystem bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2/bison-lib -isystem external/bison_v3.3.2/gnulib/lib -isystem bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2/gnulib/lib -isystem external/bison_v3.3.2/gnulib/config-darwin -isystem bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2/gnulib/config-darwin -g0 -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c external/bison_v3.3.2/src/InadequacyList.c -o bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bison_v3.3.2/_objs/bison_lib/InadequacyList.o)
# Configuration: 3aa3b11ab62daf04497b878b9b190a0b1603acc7cb04d6e97bb5b4f766ba8550
# Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
/opt/homebrew/Library/Homebrew/shims/super/cc:490:in `exec': No such file or directory - /opt/homebrew/Library/Homebrew/shims/super/xcrun (Errno::ENOENT)
    from /opt/homebrew/Library/Homebrew/shims/super/cc:490:in `<main>'
[26 / 120] [Prepa] Executing genrule //common/util:version_header ... (3 actions, 1 running)
INFO: Elapsed time: 27.957s, Critical Path: 1.17s
INFO: 29 processes: 28 internal, 1 processwrapper-sandbox.
FAILED: Build did NOT complete successfully

If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/chipsalliance/homebrew-verible/issues

[thuvasooriya]

@rkshthrmsh I’ve tried building it today. It works fine for me. I couldn’t make sense of the last 15 lines of log you presented. Maybe if you could send the whole log I’ll see if I can help.