chipsalliance / riscv-dv

Random instruction generator for RISC-V processor verification
Apache License 2.0
1.02k stars 329 forks source link

Remove unused local variables and fix gen_callback #981

Closed HuashuQ closed 4 months ago

HuashuQ commented 5 months ago
  1. There are some unused local variables from function parameters so I remove them.
  2. __init__ of class riscv_program has no input parameter but self
  3. class riscv_asm_program_gen has no member 'callstack_gen'. It's a local variable in function 'gen_callstack'
HuashuQ commented 5 months ago

@aneels3 Can you review this?

CVYang commented 2 days ago

why closed the push? i think the bug is also unfixed