chipsalliance / rocket-chip

Rocket Chip Generator
Other
3.28k stars 1.14k forks source link

Is io.resp.data in rocket/icache.scala even used? #408

Closed jackkoenig closed 8 years ago

jackkoenig commented 8 years ago

From

class ICacheResp(implicit p: Parameters) extends CoreBundle()(p) with HasL1CacheParameters {
  val data = Bits(width = coreInstBits)
  val datablock = Bits(width = rowBits)
}

As far as I can tell, only datablock is used.

ccelio commented 8 years ago

Is it not? I've never seen datablock before, but I use data in BOOM.

https://github.com/ucb-bar/riscv-boom/blob/master/src/main/scala/fetch.scala#L129

colinschmidt commented 8 years ago

Hwacha uses datablock

colinschmidt commented 8 years ago

@ccelio I think you are instantiating the frontend not the ICache itself so thats why you use data and not datablock. Hwacha has its own frontend and so instantiates the actual ICache to use its datablock.

ccelio commented 8 years ago

Oh, good point.