chipsalliance / t1

Apache License 2.0
118 stars 23 forks source link

CIRCT & Chisel bumping needs to be re-enable #787

Closed Avimitin closed 3 weeks ago

Avimitin commented 1 month ago

The latest Chisel on master branch will breaks our arithmetic module with following error:

> [error]            ^
> [error] /build/source/dependencies/arithmetic/arithmetic/src/division/srt/srt4/SRT4.scala:9:8: object leftShift is not a member of package chisel3.utils
> [error] import utils.leftShift
> [error]        ^
> [error] /build/source/dependencies/arithmetic/arithmetic/src/division/srt/srt8/SRT8.scala:7:8: object leftShift is not a member of package chisel3.utils
> [error] import utils.leftShift
> [error]        ^
> [error] /build/source/dependencies/arithmetic/arithmetic/src/division/srt/srt16/SRT16.scala:6:8: object leftShift is not a member of package chisel3.utils
> [error] import utils.leftShift
> [error]        ^
> [error] /build/source/dependencies/arithmetic/arithmetic/src/division/srt/srt16/QDS.scala:8:8: object extend is not a member of package chisel3.utils
> [error] import utils.{extend, sIntToBitPat}
> [error]        ^
> [error] /build/source/dependencies/arithmetic/arithmetic/src/division/srt/srt16/QDS.scala:19:32: not found: value sIntToBitPat
> [error]         case x => bitPatToUInt(sIntToBitPat(-x, rWidth))
> [error]                                ^
> [error] /build/source/dependencies/arithmetic/arithmetic/src/division/srt/srt16/SRT16.scala:96:7: not found: value leftShift
> [error]       leftShift(a(1), radixLog2).head(rWidth),
> [error]       ^
> [error] /build/source/dependencies/arithmetic/arithmetic/src/division/srt/srt16/SRT16.scala:97:7: not found: value leftShift
> [error]       leftShift(a(0), radixLog2 + 1).head(rWidth),
> [error]       ^
> [error] 36 errors found

But currently we have no plan to rewrite the arithmetic module, so that the Chisel bump action will never success. Before we migrate to DWBB, the CIRCT & Chisel bumping action is disabled.

Avimitin commented 1 month ago

To re-enable action, goes to the action page and scroll down to Chisel and CIRCT bumping page, click the "Enable workflow" button.

image