search

chipsalliance / verible-linter-action

Automatic SystemVerilog linting in github actions with the help of Verible
Apache License 2.0
27 stars 13 forks source link

Workflow doesn't work when the `github_token` is not specified #33

Open V0XNIHILI opened 9 months ago

V0XNIHILI commented 9 months ago

Same issue is present for the formatter: https://github.com/chipsalliance/verible-formatter-action/issues/17

In the README, it writes: "If you don't wish to use the automatic PR review, you can omit the github_token".

However, this doesn't seem to work for me, see example output log here: https://github.com/V0XNIHILI/parametrizable-floating-point-verilog/actions/runs/7738827016/job/21100439503?pr=23 (for code: https://github.com/V0XNIHILI/parametrizable-floating-point-verilog/pull/23/commits/0097a9df2cf3c1494c5d5b81f30e3390db6be8e6)

tgorochowik commented 9 months ago

Thank you for the report! I can confirm the issue, apparently https://api.github.com/repos/chipsalliance/verible/releases/latest is no longer accessible without the token.

I don't think we can do much about it for now, the workarounds I see is providing a specific verible version when used without github_token (to be verified if it works).

We probably need to update the README to reflect this.

Would you be willing to submit a PR with the update?