chipsalliance / verible

Verible is a suite of SystemVerilog developer tools, including a parser, style-linter, formatter and language server
https://chipsalliance.github.io/verible/
Other
1.38k stars 214 forks source link

Ban use of defparam #12

Closed fangism closed 4 years ago

fangism commented 4 years ago

Our to-be-published style guide explicitly bans the use of the defparam construct. This feature request aims to enforce just that.

Assignment: Implement this check as a rule inside here: https://github.com/google/verible/tree/master/verilog/analysis/checkers

Include unit-tests, positive and negative.

Add a TODO to enable by default here: https://github.com/google/verible/blob/master/verilog/analysis/default_rules.h

Add an integration test here: https://github.com/google/verible/blob/master/verilog/tools/lint/BUILD

Suggestion: Use a syntax tree matcher, starts with 'Nodek', defined in https://github.com/google/verible/blob/master/verilog/CST/verilog_matchers.h

Questions? ask in verible-dev@groups.google.com! https://groups.google.com/forum/#!forum/verible-dev

fangism commented 4 years ago

b/138351837