chipsalliance / verible

Verible is a suite of SystemVerilog developer tools, including a parser, style-linter, formatter and language server
https://chipsalliance.github.io/verible/
Other
1.38k stars 214 forks source link

want space between return keyword and following expression #493

Closed fangism closed 4 years ago

fangism commented 4 years ago

Test case

  function int foo(logic [31:0] data);
    return {<<8{data}};
  endfunction

Actual output

  function int foo(logic [31:0] data);
    return{<<8{data}};
  endfunction

Expected or suggested output

[should be the original spacing after return]

fangism commented 4 years ago

b/169194747

ahmedkrmn commented 4 years ago

Hi @fangism, Can I take this one too?

fangism commented 4 years ago

Thank you.

fangism commented 4 years ago

This is the function you'll want to update: https://cs.opensource.google/verible/verible/+/master:verilog/formatting/token_annotator.cc;bpv=1;bpt=1;l=552?gsn=SpacesRequiredBetween&gs=kythe%3A%2F%2Fgithub.com%2Fgoogle%2Fverible%3Flang%3Dc%252B%252B%3Fpath%3Dverilog%2Fformatting%2Ftoken_annotator.cc%23ROmaSUMU_uyvJwD04Z9lzyIO9K0QZQn_6cJo7pfIUAg

DhairyaBahl commented 4 years ago

@fangism I can't see any activity on this from few days. If its still available, Kindly assign it to me.

Thanks :)

ahmedkrmn commented 4 years ago

Hi, I've been busy lately, but I will start working on it this weekend.

On Thu, Oct 15, 2020, 11:52 AM DhairyaBahl notifications@github.com wrote:

@fangism https://github.com/fangism I can't see any activity on this from few days. If its still available, Kindly assign it to me.

Thanks :)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/google/verible/issues/493#issuecomment-709056118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7MCZU7G5SYJRG6STWE2LTSK3A65ANCNFSM4RWM4WDQ .

DhairyaBahl commented 4 years ago

@ahmedkrmn No offense bro. I was just finding some issues for me ;)

fangism commented 4 years ago

Thanks, both of you for offering!