fix(parser): allow `-` (hyphen) to appear in usernames

[westernwontons]

Fixes #197

Usernames may contains hyphens now. Examples:

some-user, -some-user, some-user-

Further solutions

Introduce regex to deal with parsing the input into a Destination. On one hand, it has the potential to make the code simpler. On the other hand, it's a dependency on the regex crate.

[chipsenkbeil]

@westernwontons this project has a lot of dependencies, and in fact we use regex in the distant-core crate right now: https://github.com/chipsenkbeil/distant/blob/4fb9045152ead6cbdee87f8cd67d9081ff765b0d/distant-core/Cargo.toml#L27

So I'm not opposed to using it, but it's a case of "don't fix what's not broken." So unless the regex fixes a bunch of issues or speeds up performance, I'm not necessarily inclined to introduce it right now. Open for discussion, though!

[chipsenkbeil]

@westernwontons can you update the changelog with your fix?

[westernwontons]

@westernwontons can you update the changelog with your fix?

absolutely

[westernwontons]

@westernwontons this project has a lot of dependencies, and in fact we use regex in the distant-core crate right now:

https://github.com/chipsenkbeil/distant/blob/4fb9045152ead6cbdee87f8cd67d9081ff765b0d/distant-core/Cargo.toml#L27

So I'm not opposed to using it, but it's a case of "don't fix what's not broken." So unless the regex fixes a bunch of issues or speeds up performance, I'm not necessarily inclined to introduce it right now. Open for discussion, though!

I very much agree with you, I was mentioning it as an alternative in the future if it might become necessary