chipsenkbeil / distant

🚧 (Alpha stage software) Library and tooling that supports remote filesystem and process operations. 🚧
https://distant.dev
578 stars 12 forks source link

Fix `distant fs set-permissions 'go-w' /path/to/file.txt` #221

Closed chipsenkbeil closed 1 year ago

chipsenkbeil commented 1 year ago

Currently, this is broken. We are applying a permission change to an empty mode (000) rather than the file's existing mode.

To fix this, we need to query for the file's mode first using a call to metadata and then update it using the symbolic mode information.

chipsenkbeil commented 1 year ago

There were also issues with the distant-local implementation affecting setting write permissions.

Both of these issues have been resolved by https://github.com/chipsenkbeil/distant/commit/22f3c2dd765675b7a5fcf8c9465ae2224bda7d33.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.