chipsenkbeil / vimwiki-rs

Rust library and tooling to parse, render, and modify vimwiki text and files.
56 stars 2 forks source link

Remove position information from region #99

Closed chipsenkbeil closed 3 years ago

chipsenkbeil commented 3 years ago

Position information isn't normally included at the vimwiki parser level because of how expensive it is. Would be good to simplify codebase by removing that logic entirely. Region includes the byte offset and length already, so let's make it up to the end user if they want to calculate the line and column position from a file and that information.

chipsenkbeil commented 3 years ago

Resolved by https://github.com/chipsenkbeil/vimwiki-rs/commit/4695d472c2683476a8c64b0cb145bbe196f5a0a7.