chipsenter / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUMMARY #11

Open chelBot opened 7 years ago

chelBot commented 7 years ago

Grade: Meets Expectations

Summary: Well done replicating a challenging layout using flexbox entirely from scratch! Your media queries were correct and I was pleased to see the semantic header, footer and nav tags being correctly used. You picked a nice high contrast color scheme which improves page accessibility. Your code was extremely well formatted, well commented, and well structured throughout. You had no horizontal scrolling in mobile view and I loved your transition effects!

Moving forward, I encourage you to start thinking a bit more about accessibility. For example, start including alternative text within your img tags and consider using more semantic markup. You may not have learned about this concept yet but you will soon. For a very brief overview now, take a look at this article: https://www.codecademy.com/articles/accessibility

Overall, you did a fine job on this project! It seems you have really learned a lot these last 7 weeks or so and you should feel proud! Keep up the hard work.

chipsenter commented 7 years ago

Thanks for great feedback.

I will continue my Web Development journey for sure! I really love this challenge! It's hard and that makes it even more fun. Thanks for a great course! hope you will have something similar in JavaScript because I would love to learn more about that as well.

cheers