Submitting Rails Pre-work

chipset508 commented 8 years ago

Hi CodeSchool Here is my Ruby on Rails Pre-work @coderschoolreview

coderschoolreview commented 8 years ago

Thank you for your Rails submission, chipset508!

:smile: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

nvh0412 commented 8 years ago

Hi @chipset508

Thanks for your submission! Good work.

For a quick review, your submission is good, but if you have free time, you should improve your assignment and try to complete remaining option stories as well.

Suggestions

In your route file you still didn't configure for home page. So user will seen an error page of heroku when users go to your homepage :scream: , please refer this document
In your article controller your view of show action has been shown wrong markdown format, since you didn't initial markdown object for this action.
Finally, I'd recommend taking a look at validations.

Let us know if you have any questions. /cc @coderschoolreview @harley.

chipset508 commented 8 years ago

Hi @nvh0412

Thank you for your review and suggestions my app. I will do these suggestions in my free time. I received a email notification from github which said "And YES, welcome to Ruby course of coderschool" but i could not find it in here so what happened? and if i get involved in this course where can i find more info?

chipset508 commented 8 years ago

I just fixed 2 first suggestions

chipset508 / CodeschoolPrework

Submitting Rails Pre-work #1

Thank you for your Rails submission, chipset508!

Suggestions