search

chipweinberger / dart_melty_soundfont

A port of Melty Synth by Nobuaki Tanaka (C#) to Dart
Other
33 stars 8 forks source link

modify to be a valid package #2

Closed marrlex closed 2 years ago

marrlex commented 2 years ago

Please merge this and update version numbering. The src directory is moved into lib directory, and modify lib/src/synthesizer.dart not to use flutter package (to keep it pure dart). If there are multiple necessary imports, you can export them from single file.

chipweinberger commented 2 years ago

Thanks for your contribution.

Some of these changes have already been taken. Can you rebase?

chipweinberger commented 2 years ago

also please update changelog and pubspec.yaml

marrlex commented 2 years ago

I worked from your latest main branch. Looking at the history, it is probably incompletely committed. I confirm that you have moved the directory on your repository.

I think I should not be involved in the change log or version. Because I don't know which to merge and how. Would you please edit them yourself?

chipweinberger commented 2 years ago

indeed. just pushed.