search

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
583 stars 268 forks source link

Fixed missing post_meta div around tag cloud #170

Closed atticoder closed 3 years ago

atticoder commented 3 years ago

Changes / fixes

Fixed missing "post_meta" div around tag cloud when post has tags but showShare, showDate and showReadTime were all set to false.

onweru commented 3 years ago

@atticoder, your recent PRs have removed the calendar icon and the readtime from the post meta. I will consider reverting them if those items are not restored asap. My bad, I skimmed through the commits in hurry; I didn't test.

Original preferred look

Screen Shot 2021-04-22 at 1 06 31 PM

Current look after PRs

Screen Shot 2021-04-22 at 1 06 20 PM
atticoder commented 3 years ago

@onweru, ok, I see what the issue is. If params showPostDate etc are not present in site config or head matter, it must be considered true by default, not false. My change assumed if not present equals false by default. Will fix.