chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
582 stars 267 forks source link

added missing fileWeb assignment in case of pagebundle #271

Closed yogendra closed 2 years ago

yogendra commented 2 years ago

This PR fixes broken images for sites using page bundles.

After updating to latest version 907d62a, images on my pages stopped showing up. I use page bundles.

Changes / fixes

Screenshots (if applicable)

(prefer animated gif)

Checklist

Ensure you have checked off the following before submitting your PR.

rootwork commented 2 years ago

Just reading the fix it looks good, but I won't have a chance to actually test it until Monday.

rootwork commented 2 years ago

@chipzoller @onweru I can confirm that this works locally and fixes the issue. #278 is still in progress and will address this more fully, but in the meantime we should merge this to fix error messages.

Since I am new as a maintainer I don't want to merge blindly in case there is some kind of process, so please give the green light or go ahead and merge if things look good to you.

rootwork commented 2 years ago

@chipzoller @onweru Just pinging to make sure you saw the above.

onweru commented 2 years ago

Looks all good. Please merge @rootwork.