chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
582 stars 267 forks source link

Did I meet bugs,or I lost something?? #277

Closed github-lym closed 2 years ago

github-lym commented 2 years ago

I have checked all the prerequisites below and I'm yet experiencing a problem

I installed the theme by Option 1 & 2 in Getting up and running.

And all have same result.

1. /config/_default/params.toml set codeMaxLines = 7 But the code always shows full content,can not been collapsed. notfold

2. /config/_default/params.toml set usePageBundles = true and my webcontent tree is below:

content
│  about.md
│  about.pt.md
│  archives.md
│  search.md
│  _index.md
│
├─homepage
│      about.md
│      index.md
│      work.md
│
└─post
    │  emoji-support.md
    │  markdown-syntax.md
    │  markdown-syntax.pt.md
    │  math-typesetting.md
    │  notices.md
    │  placeholder-text.md
    │  rich-content.md
    │  _index.md
    │
    └─2022
            2.png
            index.md

I added 2022 folder that has 'index.md' ,2.png in it. I want to show a image => ![](2.png) in index.md It did not show. 001

I put the 2.png in the content folder,it will show.
002

Any ideas??

chipzoller commented 2 years ago

I think a more thorough explanation is needed here.

github-lym commented 2 years ago

You are so kind. I updated the description,is it better? If not clear enough,please tell me, Thanks!

github-lym commented 2 years ago

Simplely,two problem.

  1. I want use Page Bundles, set usePageBundles = true. In the content\post\ ,add a folder named 2022, in 2022 add index.md & 2.png. I writed ![](2.png) in index.md ,but It did not show.

  2. In code block,it always shows full code,can not fold(collapse).

I installed the theme by Option 1 & 2 in Getting up and running, and different machines. And all have same result.

rootwork commented 2 years ago

For item 1 in the most recent comment - I think #271 will fix this.

For item 2 in the most recent comment - going back to the screenshot at the top, it looks like 88 lines are being displayed AND the expansion icon ("...") is showing. I don't know enough about that code to know why; maybe JS isn't loading?

github-lym commented 2 years ago

For item 1 in the most recent comment - I think #271 will fix this.

Yes!! You are right!!

Thank you very much!!

I add the code in layouts/_default/_markup/render-image.html, the image been shown!! So it is a bug.

For item 2 in the most recent comment - going back to the screenshot at the top, it looks like 88 lines are being displayed AND the expansion icon ("...") is showing. I don't know enough about that code to know why; maybe JS isn't loading?

Because I am not a coder,so I do not know why either. The live demo can toggle to show full code block or not. I do not know what should do. Toggle block expansion/contraction (dynamic)

I installed several times,but the example site's toggle block expansion/contraction (dynamic) never work.

chipzoller commented 2 years ago

Filed an issue for the code max lines at #280

rootwork commented 2 years ago

For clarity I am going to go ahead and close this issue, since from the original report the first item is now captured in #280 and the second was fixed.