Correctly load local featured images in page bundles - Githubissues

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity

Other

572 stars 263 forks source link

Correctly load local featured images in page bundles #292

Closed rootwork closed 2 years ago

rootwork commented 2 years ago

This PR...

Changes / fixes

291

This was a dumb mistake; I should have realized it was necessary after #285.

I checked, incidentally, and the meta image (opengraph etc.) doesn't require any changes; it is loading correctly.

Screenshots (if applicable)

It's easier to just explain:

In exampleSite/content/post/bundle/index.md, change featuredImage from a URL to 'building.png'.
Without this change, the image won't load, because it looks at <baseURL>/building.png.
With this change, the images loads correctly at <baseURL>/post/bundle/building.png.

Without this change the image is not there

Checklist

Ensure you have checked off the following before submitting your PR.

[x] tested locally with the latest release of Hugo. This requirement is a standard
[x] added new dependencies (n/a)
[x] updated the [docs]() ⚠️ (n/a)

rootwork commented 2 years ago

Tested with both bundle and non-bundle images, both featured and thumbnail images, and with both local and remote images.

Since this is a significant bug and it's almost identical to the fix from #285 that was already merged, I'm going to go ahead and merge that. If I overlooked something I don't think featured images could be more broken.