search

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
572 stars 263 forks source link

fix post_meta to prevent redirect #314

Closed ShoGinn closed 2 years ago

ShoGinn commented 2 years ago

just a simple fix to prevent a 301

This PR...

Changes / fixes

-

Screenshots (if applicable)

(prefer animated gif)

Checklist

Ensure you have checked off the following before submitting your PR.

rootwork commented 2 years ago

Hi @ShoGinn thanks for your contributions. A few things we need before we can review this:

  1. Please be more detailed in describing what it is you're trying to fix and what you're changing. Where are you seeing the redirects? How does your fix address it? This is particularly important since there isn't a corresponding issue. It's fine to go right to creating a PR if you see a problem and know how to fix it, but in that case you need to be a little more descriptive in what the fix is addressing.
  2. Please include a description of everything this PR does, which seems to do many more things (based on the commit messages) than affect post_meta.
  3. Linting what you're working on is fine, but please don't just lint the whole codebase and include it in a PR. Many of the files that appear to be affected are simply formatting changes. If you want to propose project-wide linting rules, make that a PR all by itself, and let's agree on the rules before actually applying the linting itself.
ShoGinn commented 2 years ago

looks like I failed on this update ;) apparently its parsing all my updates.. let me restart this!